Skip to content

[ATL-1539] Integrate FWUploader into IDE #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2021
Merged

[ATL-1539] Integrate FWUploader into IDE #466

merged 1 commit into from
Jul 28, 2021

Conversation

fstasi
Copy link
Contributor

@fstasi fstasi commented Jul 27, 2021 •
edited by per1234
Loading

Why

We need to bundle the firmware uploader into the IDE

How

  • added download script
  • updated package.json accordingly
  • exposed the fw uploader executable via executable-service-impl.ts

@fstasi fstasi requested a review from AlbyIanna July 27, 2021 14:16
@fstasi fstasi force-pushed the atl-1539--integrate-fw-uploader branch from 2119f6f to e04a098 Compare July 27, 2021 14:24
AlbyIanna
AlbyIanna approved these changes Jul 27, 2021
View reviewed changes
Copy link
Contributor

@AlbyIanna AlbyIanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fstasi fstasi force-pushed the atl-1539--integrate-fw-uploader branch from e04a098 to 8b5cc2d Compare July 28, 2021 13:40
@fstasi fstasi force-pushed the atl-1539--integrate-fw-uploader branch from 8b5cc2d to 86a9b21 Compare July 28, 2021 13:49
@fstasi fstasi merged commit 20c2e1c into main Jul 28, 2021
@fstasi fstasi deleted the atl-1539--integrate-fw-uploader branch July 28, 2021 14:42
@rsora rsora mentioned this pull request Oct 20, 2021
Closed
@per1234 per1234 added topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement labels Oct 24, 2021
@per1234 per1234 changed the title [ATL-1539] Integrate FWUploader into IDE2 [ATL-1539] Integrate FWUploader into IDE Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlbyIanna AlbyIanna AlbyIanna approved these changes

Assignees
No one assigned
Labels
topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fstasi @AlbyIanna @per1234